-
Notifications
You must be signed in to change notification settings - Fork 16
Add requests monitoring #151
Conversation
Bumped for docker/model-runner@5449fc9. See all changes in docker/model-runner@5341c9f...38bb017. Signed-off-by: Dorin Geman <[email protected]>
Signed-off-by: Dorin Geman <[email protected]>
xenoscopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I still agree with @ilopezluna that it'd be worth combining the two endpoints and differentiating on Accept if in docker/model-runner#157 if it's not too much work.
Differentiate regular and streaming based on the Accept Header. Signed-off-by: Dorin Geman <[email protected]>
Signed-off-by: Dorin Geman <[email protected]>
…indows/arm64 Signed-off-by: Dorin Geman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new requests command to the Docker Model CLI that fetches requests and responses from the Docker Model Runner, enabling monitoring of model inference activities. The implementation includes both one-shot and streaming modes with optional model filtering.
- Adds
docker model requestscommand with streaming and filtering capabilities - Updates dependencies to include model-runner support for request monitoring
- Provides comprehensive documentation and CLI completion for the new feature
Reviewed Changes
Copilot reviewed 8 out of 89 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates model-runner and model-distribution dependencies to support request monitoring |
| docs/reference/model_requests.md | Adds documentation for the new requests command |
| docs/reference/model.md | Updates parent command documentation to include requests subcommand |
| docs/reference/docker_model_requests.yaml | Defines CLI specification for requests command options |
| docs/reference/docker_model.yaml | Updates parent command specification to include requests |
| desktop/desktop.go | Implements HTTP client method for fetching requests with streaming support |
| commands/root.go | Registers the new requests command with the CLI |
| commands/requests.go | Implements the requests command with streaming, filtering, and completion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Dorin Geman <[email protected]>
Add requests monitoring. It uses docker/model-runner#157.
In docker/model-runner#157:
Here:
Note the completion added for
--model.TODO: Add
--format.